SUSE: CVE-2024-36938: SUSE Linux Security Advisory

SUSE: CVE-2024-36938: SUSE Linux Security Advisory

Severity

5

CVSS

(AV:L/AC:L/Au:S/C:N/I:N/A:C)

Published

05/30/2024

Created

06/14/2024

Added

06/13/2024

Modified

01/28/2025

Description

In the Linux kernel, the following vulnerability has been resolved: bpf, skmsg: Fix NULL pointer dereference in sk_psock_skb_ingress_enqueue Fix NULL pointer data-races in sk_psock_skb_ingress_enqueue() which syzbot reported [1]. [1] BUG: KCSAN: data-race in sk_psock_drop / sk_psock_skb_ingress_enqueue write to 0xffff88814b3278b8 of 8 bytes by task 10724 on cpu 1: sk_psock_stop_verdict net/core/skmsg.c:1257 [inline] sk_psock_drop+0x13e/0x1f0 net/core/skmsg.c:843 sk_psock_put include/linux/skmsg.h:459 [inline] sock_map_close+0x1a7/0x260 net/core/sock_map.c:1648 unix_release+0x4b/0x80 net/unix/af_unix.c:1048 __sock_release net/socket.c:659 [inline] sock_close+0x68/0x150 net/socket.c:1421 __fput+0x2c1/0x660 fs/file_table.c:422 __fput_sync+0x44/0x60 fs/file_table.c:507 __do_sys_close fs/open.c:1556 [inline] __se_sys_close+0x101/0x1b0 fs/open.c:1541 __x64_sys_close+0x1f/0x30 fs/open.c:1541 do_syscall_64+0xd3/0x1d0 entry_SYSCALL_64_after_hwframe+0x6d/0x75 read to 0xffff88814b3278b8 of 8 bytes by task 10713 on cpu 0: sk_psock_data_ready include/linux/skmsg.h:464 [inline] sk_psock_skb_ingress_enqueue+0x32d/0x390 net/core/skmsg.c:555 sk_psock_skb_ingress_self+0x185/0x1e0 net/core/skmsg.c:606 sk_psock_verdict_apply net/core/skmsg.c:1008 [inline] sk_psock_verdict_recv+0x3e4/0x4a0 net/core/skmsg.c:1202 unix_read_skb net/unix/af_unix.c:2546 [inline] unix_stream_read_skb+0x9e/0xf0 net/unix/af_unix.c:2682 sk_psock_verdict_data_ready+0x77/0x220 net/core/skmsg.c:1223 unix_stream_sendmsg+0x527/0x860 net/unix/af_unix.c:2339 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x140/0x180 net/socket.c:745 ____sys_sendmsg+0x312/0x410 net/socket.c:2584 ___sys_sendmsg net/socket.c:2638 [inline] __sys_sendmsg+0x1e9/0x280 net/socket.c:2667 __do_sys_sendmsg net/socket.c:2676 [inline] __se_sys_sendmsg net/socket.c:2674 [inline] __x64_sys_sendmsg+0x46/0x50 net/socket.c:2674 do_syscall_64+0xd3/0x1d0 entry_SYSCALL_64_after_hwframe+0x6d/0x75 value changed: 0xffffffff83d7feb0 -> 0x0000000000000000 Reported by Kernel Concurrency Sanitizer on: CPU: 0 PID: 10713 Comm: syz-executor.4 Tainted: GW6.8.0-syzkaller-08951-gfe46a7dd189e #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024 Prior to this, commit 4cd12c6065df ("bpf, sockmap: Fix NULL pointer dereference in sk_psock_verdict_data_ready()") fixed one NULL pointer similarly due to no protection of saved_data_ready. Here is another different caller causing the same issue because of the same reason. So we should protect it with sk_callback_lock read lock because the writer side in the sk_psock_drop() uses "write_lock_bh(&sk->sk_callback_lock);". To avoid errors that could happen in future, I move those two pairs of lock into the sk_psock_data_ready(), which is suggested by John Fastabend.

Solution(s)

• suse-upgrade-cluster-md-kmp-64kb
• suse-upgrade-cluster-md-kmp-azure
• suse-upgrade-cluster-md-kmp-default
• suse-upgrade-cluster-md-kmp-rt
• suse-upgrade-dlm-kmp-64kb
• suse-upgrade-dlm-kmp-azure
• suse-upgrade-dlm-kmp-default
• suse-upgrade-dlm-kmp-rt
• suse-upgrade-dtb-allwinner
• suse-upgrade-dtb-altera
• suse-upgrade-dtb-amazon
• suse-upgrade-dtb-amd
• suse-upgrade-dtb-amlogic
• suse-upgrade-dtb-apm
• suse-upgrade-dtb-apple
• suse-upgrade-dtb-arm
• suse-upgrade-dtb-broadcom
• suse-upgrade-dtb-cavium
• suse-upgrade-dtb-exynos
• suse-upgrade-dtb-freescale
• suse-upgrade-dtb-hisilicon
• suse-upgrade-dtb-lg
• suse-upgrade-dtb-marvell
• suse-upgrade-dtb-mediatek
• suse-upgrade-dtb-nvidia
• suse-upgrade-dtb-qcom
• suse-upgrade-dtb-renesas
• suse-upgrade-dtb-rockchip
• suse-upgrade-dtb-socionext
• suse-upgrade-dtb-sprd
• suse-upgrade-dtb-xilinx
• suse-upgrade-gfs2-kmp-64kb
• suse-upgrade-gfs2-kmp-azure
• suse-upgrade-gfs2-kmp-default
• suse-upgrade-gfs2-kmp-rt
• suse-upgrade-kernel-64kb
• suse-upgrade-kernel-64kb-devel
• suse-upgrade-kernel-64kb-extra
• suse-upgrade-kernel-64kb-livepatch-devel
• suse-upgrade-kernel-64kb-optional
• suse-upgrade-kernel-azure
• suse-upgrade-kernel-azure-base
• suse-upgrade-kernel-azure-devel
• suse-upgrade-kernel-azure-extra
• suse-upgrade-kernel-azure-livepatch-devel
• suse-upgrade-kernel-azure-optional
• suse-upgrade-kernel-azure-vdso
• suse-upgrade-kernel-debug
• suse-upgrade-kernel-debug-devel
• suse-upgrade-kernel-debug-livepatch-devel
• suse-upgrade-kernel-debug-vdso
• suse-upgrade-kernel-default
• suse-upgrade-kernel-default-base
• suse-upgrade-kernel-default-base-rebuild
• suse-upgrade-kernel-default-devel
• suse-upgrade-kernel-default-extra
• suse-upgrade-kernel-default-livepatch
• suse-upgrade-kernel-default-livepatch-devel
• suse-upgrade-kernel-default-man
• suse-upgrade-kernel-default-optional
• suse-upgrade-kernel-default-vdso
• suse-upgrade-kernel-devel
• suse-upgrade-kernel-devel-azure
• suse-upgrade-kernel-devel-rt
• suse-upgrade-kernel-docs
• suse-upgrade-kernel-docs-html
• suse-upgrade-kernel-kvmsmall
• suse-upgrade-kernel-kvmsmall-devel
• suse-upgrade-kernel-kvmsmall-livepatch-devel
• suse-upgrade-kernel-kvmsmall-vdso
• suse-upgrade-kernel-macros
• suse-upgrade-kernel-obs-build
• suse-upgrade-kernel-obs-qa
• suse-upgrade-kernel-rt
• suse-upgrade-kernel-rt-devel
• suse-upgrade-kernel-rt-extra
• suse-upgrade-kernel-rt-livepatch
• suse-upgrade-kernel-rt-livepatch-devel
• suse-upgrade-kernel-rt-optional
• suse-upgrade-kernel-rt-vdso
• suse-upgrade-kernel-rt_debug
• suse-upgrade-kernel-rt_debug-devel
• suse-upgrade-kernel-rt_debug-livepatch-devel
• suse-upgrade-kernel-rt_debug-vdso
• suse-upgrade-kernel-source
• suse-upgrade-kernel-source-azure
• suse-upgrade-kernel-source-rt
• suse-upgrade-kernel-source-vanilla
• suse-upgrade-kernel-syms
• suse-upgrade-kernel-syms-azure
• suse-upgrade-kernel-syms-rt
• suse-upgrade-kernel-zfcpdump
• suse-upgrade-kselftests-kmp-64kb
• suse-upgrade-kselftests-kmp-azure
• suse-upgrade-kselftests-kmp-default
• suse-upgrade-kselftests-kmp-rt
• suse-upgrade-ocfs2-kmp-64kb
• suse-upgrade-ocfs2-kmp-azure
• suse-upgrade-ocfs2-kmp-default
• suse-upgrade-ocfs2-kmp-rt
• suse-upgrade-reiserfs-kmp-64kb
• suse-upgrade-reiserfs-kmp-azure
• suse-upgrade-reiserfs-kmp-default
• suse-upgrade-reiserfs-kmp-rt

References

• https://attackerkb.com/topics/cve-2024-36938
• CVE - 2024-36938